[#SEL-407] allow users to selectWindow by title, rather than just by "name"

Selenium

allow users to selectWindow by title, rather than just by "name"

Created: 10/Dec/06 11:34 PM Updated: 05/Feb/08 04:37 PM

Component/s:

Pop-Up Windows

Affects Version/s:

None

Fix Version/s:

0.8.3

File Attachments:

SEL-407-selectWindow-PI.patch (5 kb)
2.

SEL-407-selectWindow.patch (7 kb)

Description

« Hide

currently, selectWindow only allows you to select windows by their internal "name" attribute, which isn't visible to end-users. We should allow users to selectWindow by the window's title as well.

All

Comments

Change History

Sort Order:

[ Permlink | « Hide ]

Matthew Purland - 13/Dec/06 03:54 PM

This would also be good for modal dialog windows which cannot be selected by their internal "name" attribute because they do not have one.

[ Permlink | « Hide ]

Matthew Purland - 14/Dec/06 04:50 PM

This patch provides the new selectWindow by title function and provides Selenium unit tests in the TestSuite.html for selecting the window by the title and verifying it.

[ Permlink | « Hide ]

Matthew Purland - 14/Dec/06 05:21 PM

The current patch does not yet as I know include support for PI mode, but I will try to support that soon.

[ Permlink | « Hide ]

Matthew Purland - 14/Dec/06 08:57 PM

Allow selectWindow to work in PI mode mode by selecting window by title. Included in the patch is an edit to the pom.xml file in order to have selenium-server pull in the local repository pulled in version of 0.8.3 of selenium-core for the selectWindow browserbot patch. With the other patch, the build should generate sources and pull in the TestSelectWindowTitle.java and use that in the PI mode tests.

This patch also implements getAllWindowNames on the server side from ~~SRC-209~~ in order to get the getAllWindowNames regex expression test in the TestSelectWindowTitle to work correctly.

[ Permlink | « Hide ]

Nelson Sproul - 18/Dec/06 04:28 PM

There is a set of jsunit tests (which I had myself never run) which suffered a failure w/ patch #1, that Dan fixed. You can run these tests by doing

cd selenium-core/trunk/code/
ant unittests

[ Permlink | « Hide ]

Nelson Sproul - 18/Dec/06 06:14 PM

Applied non-PI patch. Other one coming soon.

[ Permlink | « Hide ]

Matthew Purland - 19/Dec/06 10:01 AM

Please note that in TestSelectWindowTitle.html test you must remove the comment  otherwise there may be xlator issues.

[ Permlink | « Hide ]

Matthew Purland - 22/Dec/06 11:04 AM

This patch including the PI mode patch is depended upon by SRC-212 Will this patch be closed out soon?

[ Permlink | « Hide ]

Matthew Purland - 04/Jan/07 02:32 PM

Applied patch for PI mode in selenium-rc purland branch revision 1732.

[ Permlink | « Hide ]

Vishal - 15/Jan/07 11:34 PM

Please reply - http://forums.openqa.org/thread.jspa?threadID=6109 (Subject - Has anybody tried patching ~~SEL-407~~ for showModalDialog popup window?)

[ Permlink | « Hide ]

Matthew Purland - 08/Jun/07 04:50 PM

Added functionality to trunk as of revisoin 1822, but will not resolve this issue until unit tests are added and passing.