[#SRC-345] Bad error message when we timeout waiting for the browser to load

Selenium Remote Control

Bad error message when we timeout waiting for the browser to load

Created: 10/Sep/07 06:57 PM Updated: 12/Aug/08 05:37 PM

Component/s:

Server

Affects Version/s:

None

Fix Version/s:

None

Original Estimate:	Unknown	Remaining Estimate:	Unknown	Time Spent:	Unknown
File Attachments:	1. SRC-345.patch (11 kb)

Description

« Hide

Create a shell script that does nothing, then attempt to launch it in interactive mode with "cmd=getNewBrowserSession&1=*custom myscript.sh&2=http://www.google.com". Eventually we'll time out with an NPE, because waitForLoad in SDRH.getNewBrowserSession returns a string; it doesn't throw an exception or return a reasonable error.

All

Comments

Work Log

Change History

Sort Order:

[ Permlink | « Hide ]

Jennifer Bevan - 19/Dec/07 11:31 AM

I have a patch for this issue -- was working on a similar problem. Now the RemoteCommandException is propagated and handled, avoiding the NPE. Am testing patch now.

[ Permlink | « Hide ]

Jennifer Bevan - 19/Dec/07 11:36 AM

I've run the mvn tests on ubuntu/firefox, with no new broken tests. I've also run the server on a winxp box (standalone mode, box has no mvn) and had a better error message. Only downside is that in the tests, the log.error(String, Throwable) prints the stack trace, even when I'm expecting the exception to be thrown. The test passes, but the output may be overly alarming.

[ Permlink | « Hide ]

Jennifer Bevan - 20/Dec/07 01:11 PM

Okay -- I'm going to commit this one, so I can work on the reusing browser sessions fix (overlaps)....-jen

[ Permlink | « Hide ]

Jennifer Bevan - 20/Dec/07 01:14 PM

Submitted for revision 2110.