|
|
|
[
Permlink
| « Hide
]
Robert Zimmermann - 09/Dec/07 09:53 AM
patch for src
Opened related issue in S-CORE:
A little (somehow nice but also security related) side effect of this new command is the ability to use any browser to get a screenshot from any box src (with this patch) is running on.
Try: New bugfixed getScreenshot patch to be usable by the java-client-driver
Unfortunately this way getScreenshot will not work for at least the java-client-driver on remote-control side.
I updated the patch for remote-control. Please remove or ignore the two previous patches: With this new patch the selenium-core patch is obsolete. Uploading a patch for getting images of complete pages. You can find a description of it here:
http://browserbeaten.blogspot.com/2008/01/using-selenium-for-getting-full-image.html Please comment on it. Hi, guys.
Thanks for you efforts. It is really helpful patch. We need something similar and we are going to use your patch. So I have a couple of questions:
And the last question not related to you patch but...
I think it is better to have API like Hi Anatol,
If you use the patch, you will get the images from the client. Wrt to getting a separate element, I am working on a separate project to develop a framework for doing asserts like assertNoChange(image, image, ROI), I haven't decided if I will release it as a separate patch or a separate project yet, but I can mail it to you if you are interested. kind regards, To Anatol,
The ability to capture only the area around an element sounds like an excellent feature... But I don't think it belongs in something called "screenshot". selenium.image.capture.screen() Regardless, capturing a subset of the entire screen is out of scope for this particular JIRA issue. To Tarjei, To Robert and Tarjei,
Thank you for submitting your patches. Selenium succeeds or fails based on the collaboration between the developers and users of the framework. I really do appreciate the work you have put in here. However, as you point out, Robert, your patch is Java-specific, and I don't want to fracture API capabilities based on client language. (Things are already dicey on the browser side of the fence with different capabilities amongst the supported browsers.) A Selenium RC feature should work for all supported client libraries out of the box. To this end, I'm more a fan of Tarjei... your image processing code is awesome. And thank you providing so many test cases! And the results look great! However, I would like this patch reworked as an addition on top of Cheers, Though a lot of work has gone into the implementation of this patch, I'm closing it in favor of
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||