History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: SRC-425
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Critical Critical
Assignee: Nelson Sproul
Reporter: Serik
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Selenium Remote Control

wrong exception handling in function getString

Created: 18/Feb/08 11:24 PM   Updated: 25/Jun/08 01:26 AM
Component/s: Client Driver - PHP
Affects Version/s: 0.9.2
Fix Version/s: 1.0

Original Estimate: Unknown Remaining Estimate: Unknown Time Spent: Unknown
File Attachments: 1. Text File selenium_patch.txt (0.5 kb)



 Description  « Hide
this function returns exception if it's thrown by doCommand() function. It's absolutely unappropriate -- exception should be thrown, not returned.

Additionally, this function is declared as private. If someone wants to extend it, it will be impossible. This function should be protected.

 All   Comments   Work Log   Change History      Sort Order:
Serik - 18/Feb/08 11:30 PM
proposed patch

Nelson Sproul - 23/Mar/08 03:28 PM
Applied Serik's patch.

Serik - 25/Jun/08 01:26 AM
why this issue is not fixed actually? I downloaded selenium-remote-control-1.0-beta-1-dist.zip - it contains updated PHP client driver, but function getString still returns exception!