History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: SRC-481
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Philippe Hanrigou
Reporter: koca
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
Selenium Remote Control

method timeout in selenium.rb has wrong argument in case of Selenium

Created: 23/May/08 02:35 AM   Updated: 30/Sep/08 03:45 PM
Component/s: Client Driver - Ruby
Affects Version/s: 1.0 beta 1
Fix Version/s: 1.0

Original Estimate: 0.08h Remaining Estimate: 0.08h Time Spent: Unknown
Environment: Linux, ruby


 Description  « Hide
Since method timeout from ruby has parameter in seconds not in miliseconds there is in class SeleniumDriver bug around code:

....
169: def do_command(verb, args)
171: timeout(@timeout) do
172: http = Net::HTTP.new(@server_host, @server_port)
173: command_string = '/selenium-server/driver/?cmd=' + CGI::escape(verb)
174: args.length.times do |i|
....

variable @timeout is initialized in miliseconds, thereat fix should be like :

169: def do_command(verb, args)
171: -- timeout(@timeout) do
171: ++ timeout(@timeout/1000) do
172: http = Net::HTTP.new(@server_host, @server_port)

 All   Comments   Work Log   Change History      Sort Order:
Philippe Hanrigou - 30/Sep/08 03:45 PM
This is fixed a the timeout semantics are all now all in seconds for the Ruby driver (can also be installed as a standalone gem : sudo gem install selenium-client).

Philippe Hanrigou - 30/Sep/08 03:45 PM
Fixed with consistent second semantics