[#SRC-677] shutDownSeleniumServer lost due to refactoring - OpenQA Bug Tracker

Selenium Remote Control

shutDownSeleniumServer lost due to refactoring

Created: 04/Jun/09 09:58 AM Updated: 04/Jun/09 12:28 PM Resolved: 04/Jun/09 10:43 AM

Component/s:

Server

Affects Version/s:

1.0

Fix Version/s:

1.0.1

Environment:

N/A

Description

« Hide

Description
The command shutDownSeleniumServer does nothing when called.

Steps to reproduce
selenium = new DefaultSelenium("127.0.0.1",4444,"*firefox","http://localhost");
selenium.start();
selenium.shutDownSeleniumServer();

Expected
Selenium server and all sessions will be shut down.

Actual
Nothing happens.

Sort Order:

[ Permalink | « Hide ]

Andras Hatvani added a comment - 04/Jun/09 10:43 AM

Fixed in r2681:

renamed shutDown to shutDownSeleniumServer in SpecialCommand
+ renamed shutDown to shutDownSeleniumServer in SeleniumDriverResourceHandler.doCommand()
+ Added missing unit test

Simply renaming shutDown was safe, because it is equivalent to shutDownSeleniumServer and it never was present in the client APIs and therefore most probably never used.

[ Permalink | « Hide ]

Jason Huggins added a comment - 04/Jun/09 11:10 AM

There are some spots (mostly under the /clients directory) where I saw many mentions of "shutDown", but not "shutDownSeleniumServer".
Can you also take a look at all the references to "shutDown" in the RC code base and agree there are no more changes to make to fix the issue?

[ Permalink | « Hide ]

Andras Hatvani added a comment - 04/Jun/09 12:28 PM

Thanks for the hint a few replacements of "cmd=shutDown" with "cmd=shutDownSeleniumServer" in the build files were necessary:

Core: r2560
RC: r2683