Issue Details (XML | Word | Printable)

Key: WTR-279
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Charley Baker
Reporter: Charley Baker
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Watir

Winclicker callbacks not always freed - Patch

Created: 25/Jan/09 02:48 PM   Updated: 11/Nov/09 02:12 PM   Resolved: 22/Apr/09 01:57 PM
Component/s: Modal Web Dialog
Affects Version/s: 1.6.2
Fix Version/s: 1.6.5

File Attachments: 1. Text File clickerfix.patch (4 kB) 25/Jan/09 02:49 PM - Charley Baker



 Description  « Hide

Reported by Derek Berner on wtr-devel with a patch, adding ensure to close callbacks



Sort Order: Ascending order - Click to sort in descending order
Charley Baker added a comment - 25/Jan/09 02:49 PM

Derek Berner
to Watir

show details Jan 8 [clickerfix.patch]

Reply

In investigating why my clicker would randomly stop working in IE, I
discovered that the DL callbacks were not getting freed properly,
despite previous attempts to fix them.

This patch extracts the DL functionality out into its own method and
uses an "ensure" block to guarantee that the callbacks are freed, even
if an exception occurs.

I generated this patch using svn diff on rev. 1663 of the repository
at https://svn.openqa.org/svn/watir/trunk.


Charley Baker added a comment - 01/Feb/09 02:32 PM

Added the patch with some minor formatting tweaks.


Bret Pettichord added a comment - 22/Apr/09 01:57 PM

workaround jira bug


Charley Baker added a comment - 11/Nov/09 02:12 PM

closing this is fixed as of 1.6.2